Wrapped dictionary .values() call in list#61
Merged
pavoljuhas merged 3 commits intodiffpy:masterfrom Nov 14, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 81.19% 81.18% -0.01%
==========================================
Files 91 91
Lines 7599 7596 -3
==========================================
- Hits 6170 6167 -3
Misses 1429 1429
Continue to review full report at Codecov.
|
Author
|
@pavoljuhas @sbillinge ready for review |
Author
|
Has there been any progress on accepting this? The current version does not support writing results from multi-profile recipe, which is problematic |
Contributor
|
Pavol is pretty much awol atm. I will take a look and see if I feel
comfortable enough to merge it, though normally I would want to hear from
Pavol. This may change moving forward :(
…On Wed, Nov 13, 2019 at 9:23 AM Robert J Koch ***@***.***> wrote:
Has there been any progress on accepting this? The current version does
not support writing results from multi-profile recipe, which is problematic
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61?email_source=notifications&email_token=ABAOWUI4CMR6NPZOC5IJXF3QTQEWFA5CNFSM4JF3P5HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6JUXI#issuecomment-553425501>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUJC4V2VEI5ENJD5MQ3QTQEWFANCNFSM4JF3P5HA>
.
|
Author
|
Alright, fair enough.
On Wed, Nov 13, 2019 at 10:23 AM Simon Billinge <notifications@github.com>
wrote:
… Pavol is pretty much awol atm. I will take a look and see if I feel
comfortable enough to merge it, though normally I would want to hear from
Pavol. This may change moving forward :(
On Wed, Nov 13, 2019 at 9:23 AM Robert J Koch ***@***.***>
wrote:
> Has there been any progress on accepting this? The current version does
> not support writing results from multi-profile recipe, which is
problematic
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#61?email_source=notifications&email_token=ABAOWUI4CMR6NPZOC5IJXF3QTQEWFA5CNFSM4JF3P5HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6JUXI#issuecomment-553425501
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABAOWUJC4V2VEI5ENJD5MQ3QTQEWFANCNFSM4JF3P5HA
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61?email_source=notifications&email_token=AMSFZJAMEK34WDI5VAMEIWLQTQLYXA5CNFSM4JF3P5HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6P5UA#issuecomment-553451216>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMSFZJH3EV7JOOOR2FZ46Q3QTQLYXANCNFSM4JF3P5HA>
.
|
Test passes with diffpy.structure 3.0.1.
Member
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60, dict.values() does not return list. WIP.